Skip to content
This repository has been archived by the owner on Nov 27, 2024. It is now read-only.

Conversation

modular-magician
Copy link
Contributor

Added the ability to set the preemptibility of secondary workers as requested in hashicorp/terraform-provider-google#7882 to the existing preemptible worker config. While it's not ideal from a semantic perspective, it doesn't break anything.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

dataproc:added `preemptibility` field to the `preemptible_worker_config` of `google_dataproc_cluster`

Derived from GoogleCloudPlatform/magic-modules#5686

Co-authored-by: Matthew Barnes <matthew.simon.barnes@gmail.com>
Co-authored-by: Stephen Lewis (Burrows) <stephenrlewis@google.com>
Co-authored-by: Riley Karson <rileykarson@google.com>
Co-authored-by: Scott Suarez <ScottMSuarez@gmail.com>
Co-authored-by: Sampath Kumar <sampathm@google.com>
Co-authored-by: Sam Levenick <slevenick@google.com>
Co-authored-by: John Pellman <pellman.john@gmail.com>
Co-authored-by: Jacek Kikiewicz <jaceq@users.noreply.github.com>
Co-authored-by: Alex Ellis <alexellis@google.com>
Co-authored-by: megan07 <mbang@hashicorp.com>
Co-authored-by: Daniel Randell <drandell@users.noreply.github.com>
Co-authored-by: Iris Chen <10179943+iyabchen@users.noreply.github.com>
Co-authored-by: prateek2408 <prateek.khushalani@gmail.com>
Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician requested a review from a team as a code owner March 7, 2022 18:26
@modular-magician modular-magician requested review from melinath and removed request for a team March 7, 2022 18:26
@google-cla
Copy link

google-cla bot commented Mar 7, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

@modular-magician modular-magician merged commit 883a27c into GoogleCloudPlatform:main Mar 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant