-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for non-preemptible secondary dataproc workers #5686
Add support for non-preemptible secondary dataproc workers #5686
Conversation
…m#5649) `settings.backup_configuration.binary_log_enabled` may be true even if `settings.backup_configuration.enabled` is false. This behaviour as changed in GoogleCloudPlatform#4907 Co-authored-by: Matthew Barnes <matthew.simon.barnes@gmail.com>
…ndary_dataproc_nodes
…ndary_dataproc_nodes
…ndary_dataproc_nodes
Hello! I am a robot who works on Magic Modules PRs. I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. Thanks for your contribution! A human will be with you soon. @ScottSuarez, please review this PR or find an appropriate assignee. |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 3 files changed, 82 insertions(+), 3 deletions(-)) |
/gcbrun |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 3 files changed, 82 insertions(+), 3 deletions(-)) |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic|TestAccApigeeEnvironmentIamPolicyGenerated|TestAccBigQueryDataset_basic|TestAccBigQueryDataset_access|TestAccCloudbuildWorkerPool_basic|TestAccComputeGlobalForwardingRule_externalCndLbWithBackendBucketExample|TestAccComputeInstanceTemplate_reservationAffinities|TestAccComputeInstance_guestAccelerator|TestAccComputeInstance_guestAcceleratorSkip|TestAccDataprocCluster_nonPreemptibleSecondary|TestAccDataprocCluster_updatable|TestAccDataprocCluster_withConfigOverrides|TestAccEventarcTrigger_BasicHandWritten|TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRange|TestAccTags You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=261055 |
Isn't this already supported simply by supplying a |
It's possible I touched more than was necessary, it's my first time contributing to the repo. My intent is to extend the preemtible_worker_config so that you can configure the preemptibility of the secondary workers to be non-preemptible. The use case I'm implementing this for is a cluster for a job that only runs periodically with a large resource requirement that is sensitive to task failures, so we want autoscaling but we do not want nodes to be preempted |
/gcbrun |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 3 files changed, 82 insertions(+), 3 deletions(-)) |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDataSourceComputeRouter|TestAccDataSourceComputeRouterStatus|TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic|TestAccCloudbuildWorkerPool_basic|TestAccComputeHaVpnGateway_computeHaVpnGatewayEncryptedInterconnectExample|TestAccComputeInterconnectAttachment_interconnectAttachmentBasicExample|TestAccComputeInterconnectAttachment_computeInterconnectAttachmentIpsecEncryptionExample|TestAccComputeRouter_routerBasicExample|TestAccComputeRouter_computeRouterEncryptedInterconnectExample|TestAccComputeRouterNat_withManualIpAndSubnetConfiguration|TestAccComputeRouterNat_withDisabledIndependentEndpointMapping|TestAccComputeRouter_basic|TestAccComputeRouter_noRegion|TestAccComputeRouter_full|TestAccComputeRouter_update|TestAccComputeRouterPeer_enable|TestAccComputeRouterInterface_basic|TestAccComputeRouterInterface_withTunnel|TestAccComputeRouter_updateAddRemoveBGP|TestAccComputeRouterPeer_basic|TestAccComputeRouterPeer_advertiseMode|TestAccComputeRouterPeer_bfd|TestAccComputeVpnTunnel_router|TestAccContainerCluster_withAuthenticatorGroupsConfig|TestAccServiceNetworkingPeeredDNSDomain_basic|TestAccServiceUsageConsumerQuotaOverride_consumerQuotaOverrideExample|TestAccServiceUsageConsumerQuotaOverride_consumerQuotaOverrideZeroValueExample|TestAccServiceUsageConsumerQuotaOverride_regionConsumerQuotaOverrideExample You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=264835 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Truly a strange field. It looks good though
…udPlatform#5686) Co-authored-by: Matthew Barnes <matthew.simon.barnes@gmail.com> Co-authored-by: Stephen Lewis (Burrows) <stephenrlewis@google.com> Co-authored-by: Riley Karson <rileykarson@google.com> Co-authored-by: Scott Suarez <ScottMSuarez@gmail.com> Co-authored-by: Sampath Kumar <sampathm@google.com> Co-authored-by: Sam Levenick <slevenick@google.com> Co-authored-by: John Pellman <pellman.john@gmail.com> Co-authored-by: Jacek Kikiewicz <jaceq@users.noreply.github.com> Co-authored-by: Alex Ellis <alexellis@google.com> Co-authored-by: megan07 <mbang@hashicorp.com> Co-authored-by: Daniel Randell <drandell@users.noreply.github.com> Co-authored-by: Iris Chen <10179943+iyabchen@users.noreply.github.com> Co-authored-by: prateek2408 <prateek.khushalani@gmail.com>
…udPlatform#5686) Co-authored-by: Matthew Barnes <matthew.simon.barnes@gmail.com> Co-authored-by: Stephen Lewis (Burrows) <stephenrlewis@google.com> Co-authored-by: Riley Karson <rileykarson@google.com> Co-authored-by: Scott Suarez <ScottMSuarez@gmail.com> Co-authored-by: Sampath Kumar <sampathm@google.com> Co-authored-by: Sam Levenick <slevenick@google.com> Co-authored-by: John Pellman <pellman.john@gmail.com> Co-authored-by: Jacek Kikiewicz <jaceq@users.noreply.github.com> Co-authored-by: Alex Ellis <alexellis@google.com> Co-authored-by: megan07 <mbang@hashicorp.com> Co-authored-by: Daniel Randell <drandell@users.noreply.github.com> Co-authored-by: Iris Chen <10179943+iyabchen@users.noreply.github.com> Co-authored-by: prateek2408 <prateek.khushalani@gmail.com>
…udPlatform#5686) Co-authored-by: Matthew Barnes <matthew.simon.barnes@gmail.com> Co-authored-by: Stephen Lewis (Burrows) <stephenrlewis@google.com> Co-authored-by: Riley Karson <rileykarson@google.com> Co-authored-by: Scott Suarez <ScottMSuarez@gmail.com> Co-authored-by: Sampath Kumar <sampathm@google.com> Co-authored-by: Sam Levenick <slevenick@google.com> Co-authored-by: John Pellman <pellman.john@gmail.com> Co-authored-by: Jacek Kikiewicz <jaceq@users.noreply.github.com> Co-authored-by: Alex Ellis <alexellis@google.com> Co-authored-by: megan07 <mbang@hashicorp.com> Co-authored-by: Daniel Randell <drandell@users.noreply.github.com> Co-authored-by: Iris Chen <10179943+iyabchen@users.noreply.github.com> Co-authored-by: prateek2408 <prateek.khushalani@gmail.com>
Added the ability to set the preemptibility of secondary workers as requested in hashicorp/terraform-provider-google#7882 to the existing preemptible worker config. While it's not ideal from a semantic perspective, it doesn't break anything.
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)