Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding static_debug variant of the base image. #695

Merged
merged 1 commit into from
Apr 7, 2021

Conversation

mishas
Copy link
Contributor

@mishas mishas commented Mar 16, 2021

Closes #571 .

Necessary to close bazelbuild/rules_docker#1642

@mishas
Copy link
Contributor Author

mishas commented Apr 7, 2021

@dlorenc , Any chance you can take a look at this please?

Thank you!

@mishas mishas force-pushed the misha.static_debug branch from 070af92 to 1cc9d56 Compare April 7, 2021 02:46
@dlorenc
Copy link
Contributor

dlorenc commented Apr 7, 2021

Let's see if it works!

@mishas
Copy link
Contributor Author

mishas commented Apr 7, 2021

@dlorenc , Thanks for merging.
I tested the new images locally, and they work perfectly.

Also opened subsequent PR for rules_docker to start using it: bazelbuild/rules_docker#1804

@mishas mishas deleted the misha.static_debug branch April 7, 2021 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes CLAs look good
Projects
None yet
2 participants