Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use actual sha for static:debug image (and update static:latest) #1804

Merged
merged 1 commit into from
Apr 26, 2021

Conversation

mishas
Copy link
Contributor

@mishas mishas commented Apr 7, 2021

This PR closes #1642 .

This PR is possible due to the merging of GoogleContainerTools/distroless#695.

The change in this PR was done by running bazel run //container/go/cmd/update_deps -- --repository=gcr.io/distroless/static --output=$PWD/go/static.bzl.

CC: @kalbasit

Copy link
Contributor

@kalbasit kalbasit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It worked for me, I was able to open a shell in the static debug image.

@mishas
Copy link
Contributor Author

mishas commented Apr 23, 2021

Hello @pcj,
Thank you for approving this PR.
Any chance this can be merged (and possibly released) please?
(I would really want to move back to use official rules_docker and not my clone)

Thank you.

@alexeagle alexeagle force-pushed the update_debug_image branch from e9b2723 to acd49ef Compare April 24, 2021 15:33
@alexeagle alexeagle merged commit f929d80 into bazelbuild:master Apr 26, 2021
@mishas mishas deleted the update_debug_image branch April 26, 2021 02:06
martaver pushed a commit to cleric-sh/rules_docker that referenced this pull request May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The go_debug_image_static is the same as the go_image_static and does not include a shell
4 participants