-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update jib-core version to 0.22.0 and plugins versions to 3.3.0 #134
Conversation
Running into the following issue with 3.3.0:
Have verified locally that this plugin works fine when 3.2.1 of jib-gradle-plugin is used. Will wait a bit and re-run this test. |
Additionally, running |
Would it usually take a bit of time for the new releases to get updated in the Maven Repository? |
Hm I was also wondering that. It usually takes a couple of hours to upload. I see that 3.3.0 is available at https://plugins.gradle.org/m2/com/google/cloud/tools/jib/com.google.cloud.tools.jib.gradle.plugin/ and https://plugins.gradle.org/plugin/com.google.cloud.tools.jib but not at https://plugins.gradle.org/m2/gradle/plugin/com/google/cloud/tools/jib-gradle-plugin/ |
Removing - JIB_GRADLE: 'gradle.plugin.com.google.cloud.tools:jib-gradle-plugin:3.3.0',
+ JIB_GRADLE: 'com.google.cloud.tools:jib-gradle-plugin:3.3.0', |
oh good observation, thanks Chanseok! Will try with removing the |
Gradle in core Jib got upgraded from 6.0.1 to 6.6.1 in GoogleContainerTools/jib#3670 . Could this have caused publishing to be done without the prefix? |
That does seem like a likely cause! Which also reminds me, maybe we should upgrade the gradle version here to be consistent with the main Jib repo? |
Kudos, SonarCloud Quality Gate passed! |
Yeah, it would make sense to have consistent gradle versions. |
Afaik it may not have a major impact on how jib is configured. Our README instructions specify jib to applied the following way: |
Oh actually looking at @chanseokoh's comment, there may be a couple of cases: GoogleContainerTools/jib#3719 (comment). But the good news is that |
It will be pretty rare, as it mostly for those who want to use the jib-gradle-plugin JAR as a library (for whatever weird reasons) rather than using the Jib plugin in a Gradle build. It's not the use case we really support. |
Sounds good; not breaking the documented usecases then. |
No description provided.