⚡ Gradle build optimizations #3670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rmalization functionality
…message when plugin cannot be applied
…e classpath for changed values for task caching purposes
ryandens
commented
May 13, 2022
| @@ -137,7 +137,7 @@ public void testCheckJibVersionInvoked() { | |||
| // Gradle tests aren't run from a jar and so don't have an identifiable plugin version | |||
| assertThat(exception) | |||
| .hasMessageThat() | |||
| .isEqualTo("Failed to apply plugin [id 'com.google.cloud.tools.jib']"); | |||
| .isEqualTo("Failed to apply plugin 'com.google.cloud.tools.jib'."); | |||
There was a problem hiding this comment.
this error message changed as a result of the gradle wrapper upgrade from 6.0.1 to 6.6.1
runningcode
approved these changes
May 16, 2022
settings.gradle
Outdated
| @@ -1,3 +1,6 @@ | |||
| buildCache { | |||
There was a problem hiding this comment.
This configuration is optional since it is already the default when adding org.gradle.caching=true.
|
Kudos, SonarCloud Quality Gate passed!
|
elefeint
approved these changes
May 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3669
Before filing a pull request, make sure to do the following:
This helps to reduce the chance of having a pull request rejected.