Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

run_in_docker.sh doesn't work (or gracefully not work) with non-glcoud registires #988

Closed
rhs opened this issue Jan 22, 2020 · 3 comments · Fixed by #990
Closed

run_in_docker.sh doesn't work (or gracefully not work) with non-glcoud registires #988

rhs opened this issue Jan 22, 2020 · 3 comments · Fixed by #990
Assignees
@samos123
Labels
area/registry For all bugs having to do with pushing/pulling into registries priority/p2 High impact feature/bug. Will get a lot of users happy

Comments

@rhs
Copy link

rhs commented Jan 22, 2020

Actual behavior
I'm trying to get run_in_docker.sh to work... I'm passing in quay.io//foo as the third argument, and I keep getting permission issues with pushing to that repo
how am I supposed to give the run_in_docker.sh script credentials?

Expected behavior
I would expect there to be some instructions for passing in docker credentials to work with a normal registry. Or alternatively it should be clear (perhaps via README or an error check in the shell script) that it only works with gcr.

To Reproduce
See above.
@samos123 samos123 self-assigned this Jan 22, 2020
@tejal29
Copy link
Member

tejal29 commented Jan 23, 2020 •
edited
Loading

@rhs is this insecure private registry?

@tejal29 tejal29 added area/registry For all bugs having to do with pushing/pulling into registries priority/p2 High impact feature/bug. Will get a lot of users happy labels Jan 23, 2020
samos123 added a commit to samos123/kaniko that referenced this issue Jan 23, 2020
@samos123
Fixes GoogleContainerTools#988 run_in_docker.sh only works with gcr.io
509afaf
@samos123 samos123 mentioned this issue Jan 23, 2020
Merged
4 tasks
@samos123
Copy link
Contributor

could you try this pull request the script from this pull request to confirm whether it fixes the issue? https://github.com/samos123/kaniko/blob/fix-988-run-in-docker-sh-non-gcr/run_in_docker.sh

@samos123
Copy link
Contributor

@rhs kindly let me know if it fixed the issue for you

tejal29 added a commit that referenced this issue Jan 28, 2020
@tejal29
Merge pull request #990 from samos123/fix-988-run-in-docker-sh-non-gcr
4919fb5 
Fixes #988 run_in_docker.sh only works with gcr.io
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samos123 samos123

Labels
area/registry For all bugs having to do with pushing/pulling into registries priority/p2 High impact feature/bug. Will get a lot of users happy
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #988 run_in_docker.sh only works with gcr.io samos123/kaniko
3 participants
@rhs @samos123 @tejal29