New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #988 run_in_docker.sh only works with gcr.io #990

Merged

tejal29 merged 1 commit into GoogleContainerTools:master from samos123:fix-988-run-in-docker-sh-non-gcr

Jan 28, 2020

Contributor

samos123 commented Jan 23, 2020 •

edited by tejal29

Loading

Fixes #988 run_in_docker.sh only works with gcr.io

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

Includes unit tests
Adds integration tests if needed.

See the contribution guide for more details.

Reviewer Notes

The code flow looks good.
Unit tests and or integration tests added.


          Fixes GoogleContainerTools#988 run_in_docker.sh only works with gcr.io

509afaf

googlebot added the cla: yes label

tejal29 approved these changes

View reviewed changes

tejal29 merged commit 4919fb5 into GoogleContainerTools:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment