Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump go-containerregistry dep #1371

Merged
merged 1 commit into from
Aug 13, 2020
Merged

Conversation

jchorl
Copy link
Contributor

@jchorl jchorl commented Aug 5, 2020

Description

This PR bumps the go-containerregistry dependency. I mainly just want to grab google/go-containerregistry#750.

Specifically, I ran:

go get github.com/google/go-containerregistry@master
go mod vendor

kaniko was already using the master branch of go-containerregistry, so seems fine to bump.

No interface changes, tests still pass.

Submitter Checklist

I didn't add tests because I'm only bumping a dep

Reviewer Notes

  • The code flow looks good.
  • Unit tests and or integration tests added.

@googlebot googlebot added the cla: yes CLA signed by all commit authors label Aug 5, 2020
@jchorl
Copy link
Contributor Author

jchorl commented Aug 13, 2020

@tejal29 any chance I could trouble you to take a look? I know it's a big change by file-count - if you'd feel more comfortable, feel free to bump the dep yourself.

@tejal29 tejal29 merged commit 02896bf into GoogleContainerTools:master Aug 13, 2020
Copy link
Member

@tejal29 tejal29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay! Thanks for bumping!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes CLA signed by all commit authors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants