Retry on TOOMANYREQUESTS error from ECR #750
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it says on the tin
I made a test go program here to force 429s. The output was:
Quite obviously, go-containerregistry is not treating
TOOMANYREQUESTS
as temporary even though it is, in fact, a temporary error. This is preventing retries here because the error does implement thetemporary
interface (here) but this error is deemed non-temporary.The error manifested itself when kaniko was trying to push a bunch of images in parallel:
The error is explained in the registry spec here: https://github.com/docker/distribution/blob/master/docs/spec/api.md#errors-2
Anyway, this change causes go-containerregistry to treat a 429 as a retryable error.