Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retry on TOOMANYREQUESTS error from ECR #750

Merged
merged 2 commits into from
Aug 4, 2020
Merged

Retry on TOOMANYREQUESTS error from ECR #750

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4281d34
Retry on TOOMANYREQUESTS error from ECR
jchorl Aug 3, 2020
3dbc489
use a set instead
jchorl Aug 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions pkg/v1/remote/transport/error.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,8 +89,7 @@ func (e *Error) Temporary() bool {
return false
}
for _, d := range e.Errors {
// TODO: Include other error types.
if d.Code != BlobUploadInvalidErrorCode {
if _, ok := temporaryErrorCodes[d.Code]; !ok {
return false
}
}
Expand Down Expand Up @@ -149,8 +148,15 @@ const (
UnauthorizedErrorCode ErrorCode = "UNAUTHORIZED"
DeniedErrorCode ErrorCode = "DENIED"
UnsupportedErrorCode ErrorCode = "UNSUPPORTED"
TooManyRequestsErrorCode ErrorCode = "TOOMANYREQUESTS"
)

// TODO: Include other error types.
var temporaryErrorCodes = map[ErrorCode]struct{}{
BlobUploadInvalidErrorCode: struct{}{},
TooManyRequestsErrorCode: struct{}{},
}

// CheckError returns a structured error if the response status is not in codes.
func CheckError(resp *http.Response, codes ...int) error {
for _, code := range codes {
Expand Down
7 changes: 7 additions & 0 deletions pkg/v1/remote/transport/error_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,13 @@ func TestTemporary(t *testing.T) {
}},
},
retry: false,
}, {
error: &Error{
Errors: []Diagnostic{{
Code: TooManyRequestsErrorCode,
}},
},
retry: true,
}}

for _, test := range tests {
Expand Down