Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run docker_credentials_gcr in warmer #1780

Merged

Conversation

tejal29
Copy link
Member

@tejal29 tejal29 commented Oct 19, 2021

Since we switched to multi-arch builds, we can't run docker-credentials-gcr built for a target platform on build platform as they can be different.

In order to have backward compatibility to warmer,

  1. if any of if the warmer images is gcr.io or dev.pkg, then run docker-credentials-gcr

@google-cla google-cla bot added the cla: yes CLA signed by all commit authors label Oct 19, 2021
@tejal29 tejal29 merged commit cf4822c into GoogleContainerTools:master Oct 19, 2021
imjasonh added a commit to imjasonh/kaniko that referenced this pull request Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes CLA signed by all commit authors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant