Revert "Run docker_credentials_gcr in warmer (#1780)" #1852
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This reverts commit cf4822c.
I have a theory in #702 (comment) that this change causes the regression in v1.7.0 which also blocks us from cutting new releases.
The original justification in #1780 was that the credential helpers aren't available in multi-arch images, but since #1848 we're
go build
ing them ourselves withGOARCH
set, so that shouldn't be an issue. @tejal29 any more context on that issue might help us come up with a better solution.In any case, I don't think that change was necessary, so even if it doesn't fix the bug, we should be able to get by without it. With images being pushed for every commit we can test whether this fixes everyone's issues, and if so, we can cut a 1.8.0. If not, we can at least keep digging for the bug.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Reviewer Notes
Release Notes
Describe any changes here so maintainer can include it in the release notes, or delete this block.