-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix checkPushPermissions by --insecure #683
Conversation
Have a look at #663. |
needs PR GoogleContainerTools/kaniko#683 to be merged
until GoogleContainerTools/kaniko#683 is merged
* support insecure registry needs PR GoogleContainerTools/kaniko#683 to be merged
* support insecure registry needs PR GoogleContainerTools/kaniko#683 to be merged .... bump version [skip ci]
* support insecure registry needs PR GoogleContainerTools/kaniko#683 to be merged .... bump version [skip ci]
@kokoro-team plz check it |
@priyawadhwa @sharifelgamal With the current release 0.10 I get HTTPS issues, I created my own image from @cn-sunletian fork samyco/kaniko and it works. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM! I think you checked in the .idea
directory by accident, could you remove those files? I also don't think the vendor directory needs to be updated in this case :)
This reverts commit 25995ea.
@priyawadhwa Thank you for reminding me :) |
* support insecure registry needs PR GoogleContainerTools/kaniko#683 to be merged * save * supprt insecure and skip-verify
* support insecure registry needs PR GoogleContainerTools/kaniko#683 to be merged * save * supprt insecure and skip-verify .... bump version [skip ci]
* support insecure registry needs PR GoogleContainerTools/kaniko#683 to be merged * save * supprt insecure and skip-verify .... bump version [skip ci]
@cn-sunletian can you fix the lint errors? Looking forward to get this in! |
Our registry is harbor by http. When I push image, error occurred on function CheckPushPermissions.
Even add "--insecure" that doesn't work, but add "--insecure-pull" it can pull well.So i find "push.go" an error here. #737