-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kaniko skip tls verify #438
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 6 of 6 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @yehiyam)
core/algorithm-builder/lib/builds/build-algorithm-image-kaniko.sh, line 110 at r1 (raw file):
--insecure) INSECURE="$2"
INSECURE_PUSH?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 5 of 6 files reviewed, 1 unresolved discussion (waiting on @nassiharel)
core/algorithm-builder/lib/builds/build-algorithm-image-kaniko.sh, line 110 at r1 (raw file):
Previously, NassiHarel (Nassi Harel) wrote…
INSECURE_PUSH?
That's the name of the parameter in kaniko, so I left it like this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 5 of 6 files reviewed, 1 unresolved discussion (waiting on @nassiharel)
core/algorithm-builder/lib/builds/build-algorithm-image-kaniko.sh, line 110 at r1 (raw file):
Previously, yehiyam wrote…
That's the name of the parameter in kaniko, so I left it like this
Done.
* support insecure registry needs PR GoogleContainerTools/kaniko#683 to be merged * save * supprt insecure and skip-verify .... bump version [skip ci]
* support insecure registry needs PR GoogleContainerTools/kaniko#683 to be merged * save * supprt insecure and skip-verify .... bump version [skip ci]
This change is![Reviewable](https://camo.githubusercontent.com/1541c4039185914e83657d3683ec25920c672c6c5c7ab4240ee7bff601adec0b/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)