Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kaniko skip tls verify #438

Merged
merged 5 commits into from
Jul 29, 2019
Merged

Kaniko skip tls verify #438

merged 5 commits into from
Jul 29, 2019

Conversation

yehiyam
Copy link
Contributor

@yehiyam yehiyam commented Jul 25, 2019

This change is Reviewable

Copy link
Contributor

@nassiharel nassiharel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 6 of 6 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @yehiyam)


core/algorithm-builder/lib/builds/build-algorithm-image-kaniko.sh, line 110 at r1 (raw file):

     --insecure)
    INSECURE="$2"

INSECURE_PUSH?

Copy link
Contributor Author

@yehiyam yehiyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 5 of 6 files reviewed, 1 unresolved discussion (waiting on @nassiharel)


core/algorithm-builder/lib/builds/build-algorithm-image-kaniko.sh, line 110 at r1 (raw file):

Previously, NassiHarel (Nassi Harel) wrote…

INSECURE_PUSH?

That's the name of the parameter in kaniko, so I left it like this

Copy link
Contributor Author

@yehiyam yehiyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 5 of 6 files reviewed, 1 unresolved discussion (waiting on @nassiharel)


core/algorithm-builder/lib/builds/build-algorithm-image-kaniko.sh, line 110 at r1 (raw file):

Previously, yehiyam wrote…

That's the name of the parameter in kaniko, so I left it like this

Done.

@yehiyam yehiyam merged commit df5eb40 into master Jul 29, 2019
@yehiyam yehiyam deleted the kaniko-skip-tls-verify branch July 29, 2019 15:06
hkube-ci pushed a commit that referenced this pull request Jul 29, 2019
* support insecure registry
needs PR GoogleContainerTools/kaniko#683  to be merged

* save

* supprt insecure and skip-verify
 .... bump version [skip ci]
hkube-ci pushed a commit that referenced this pull request Jul 29, 2019
* support insecure registry
needs PR GoogleContainerTools/kaniko#683  to be merged

* save

* supprt insecure and skip-verify
 .... bump version [skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants