Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

insecure flag not honored in cache #685

Merged
merged 3 commits into from
Sep 20, 2019

Conversation

tralexa
Copy link
Contributor

@tralexa tralexa commented Jun 2, 2019

No description provided.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@tralexa
Copy link
Contributor Author

tralexa commented Jun 2, 2019 via email

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@donmccasland donmccasland merged commit ccd99fb into GoogleContainerTools:master Sep 20, 2019
priyawadhwa pushed a commit to priyawadhwa/skaffold-1 that referenced this pull request Oct 2, 2019
This PR:

1. Passes in the `--insecure-registry` flag to kaniko, which allows for
insecure image pull and pushes

2. Updates the kaniko image to one that incorporates this bug fix in
kaniko: GoogleContainerTools/kaniko#685. This
bug fix is required for insecure registries to work with caching in
kaniko.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants