-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bugs in insecure registries for kaniko #2974
Fix bugs in insecure registries for kaniko #2974
Conversation
This PR: 1. Passes in the `--insecure-registry` flag to kaniko, which allows for insecure image pull and pushes 2. Updates the kaniko image to one that incorporates this bug fix in kaniko: GoogleContainerTools/kaniko#685. This bug fix is required for insecure registries to work with caching in kaniko.
Codecov Report
|
@tejal29 I added an integration test after your approval -- could you PTAL? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent!
I ran it 10 times in parallel in 3 go test
processes. The max time each test run ran was around 4 mins.
The timeout for ip to stabilize is 5 mins in kubernetes.GetExternalIP
Lets merge it and see what happens.
This PR:
Passes in the
--insecure-registry
flag to kaniko, which allows forinsecure image pull and pushes
Updates the kaniko image to one that incorporates this bug fix in
kaniko: insecure flag not honored in cache kaniko#685. This
bug fix is required for insecure registries to work with caching in
kaniko.
Adds an integration test
I found these bugs while trying to push to my own insecure registry.
Next PRs.
n/a
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
Reviewer Notes