Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final cachekey for stage #891

Conversation

cvgw
Copy link
Contributor

@cvgw cvgw commented Nov 27, 2019

Fixes #682
Description

Store the last cachekey generated for each stage.
If the base image for a stage is present in the map of digest and cachekeys use the retrieved cachekey instead of the base image digest in the compositecache.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes unit tests
  • Adds integration tests if needed.

See the contribution guide for more details.

Reviewer Notes

  • The code flow looks good.
  • Unit tests and or integration tests added.

Release Notes

Describe any changes here so maintainer can include it in the release notes, or delete this block.

- Improve caching for multistage builds where FROM points to a locally build stage

Store the last cachekey generated for each stage
If the base image for a stage is present in the map of digest
and cachekeys use the retrieved cachekey instead of the base image
digest in the compositecache
@cvgw cvgw merged commit ee376c7 into GoogleContainerTools:master Nov 27, 2019
@cvgw cvgw deleted the u/cvgw/last-cachekey-or-base-image-digest branch November 27, 2019 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Caching fails in multi-stage build
2 participants