Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't exit optimize early; record last cachekey #892

Conversation

cvgw
Copy link
Contributor

@cvgw cvgw commented Nov 28, 2019

Description

Small fix to previous PR #891 to ensure that we don't exit the loop early and get the very last cache key

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes unit tests
  • Adds integration tests if needed.

See the contribution guide for more details.

Reviewer Notes

  • The code flow looks good.
  • Unit tests and or integration tests added.

Release Notes

@cvgw cvgw merged commit 034ac9e into GoogleContainerTools:master Nov 28, 2019
@cvgw cvgw deleted the u/cvgw/dont-break-keep-collecting-cache-keys branch November 28, 2019 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant