Skip to content

Commit

Permalink
Fix reconciler-manager cmd to accept log flags (#780)
Browse files Browse the repository at this point in the history
Previously, -v=# and other log flags were not being registered.
Not it sets up log flags the sam as other component binaries.
  • Loading branch information
karlkfi committed Jul 30, 2023
1 parent b687f90 commit fe52455
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 7 deletions.
9 changes: 2 additions & 7 deletions cmd/reconciler-manager/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ import (
"kpt.dev/configsync/pkg/profiler"
"kpt.dev/configsync/pkg/reconcilermanager"
"kpt.dev/configsync/pkg/reconcilermanager/controllers"
"kpt.dev/configsync/pkg/util/log"
ctrl "sigs.k8s.io/controller-runtime"
"sigs.k8s.io/controller-runtime/pkg/client"
// +kubebuilder:scaffold:imports
Expand All @@ -57,21 +58,15 @@ var (
setupLog = ctrl.Log.WithName("setup")
)

func init() {
// klogr flags
_ = flag.Set("v", "1")
_ = flag.Set("logtostderr", "true")
}

func main() {
var metricsAddr string
var enableLeaderElection bool
flag.StringVar(&metricsAddr, "metrics-addr", ":8080", "The address the metric endpoint binds to.")
flag.BoolVar(&enableLeaderElection, "enable-leader-election", false,
"Enable leader election for controller manager. "+
"Enabling this will ensure there is only one active controller manager.")
flag.Parse()

log.Setup()
profiler.Service()
ctrl.SetLogger(klogr.New())

Expand Down
1 change: 1 addition & 0 deletions manifests/templates/reconciler-manager.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ spec:
- /reconciler-manager
args:
- --enable-leader-election
- "-v=1"
image: RECONCILER_MANAGER_IMAGE_NAME
name: reconciler-manager
securityContext:
Expand Down

0 comments on commit fe52455

Please sign in to comment.