Fix reconciler-manager cmd to accept log flags #780
Conversation
|
|
||
| log.Setup() |
There was a problem hiding this comment.
It looks like the init function above hard codes the v flag to 1. I expect we need to remove that so that we use the actual verbosity flag that is passed in to the binary
There was a problem hiding this comment.
good catch. I guess I'll just set it to -v=1 in the manifest
There was a problem hiding this comment.
IIRC it doesn't need to be set in the manifest any more, it gets set in code now with the new logLevel api (getting a default value from code)
There was a problem hiding this comment.
nope. that's just for reconciler containers.
There was a problem hiding this comment.
oh I guess this is reconciler-manager, nevermind
Previously, -v=# and other log flags were not being registered. Not it sets up log flags the sam as other component binaries.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sdowell The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
google-oss-prow
bot
merged commit fe52455
into
GoogleContainerTools:main
Previously, -v=# and other log flags were not being registered. Not it sets up log flags the sam as other component binaries.