Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project not importable in other Go projects #4

Closed
tomasaschan opened this issue Jul 20, 2022 · 4 comments
Closed

Project not importable in other Go projects #4

tomasaschan opened this issue Jul 20, 2022 · 4 comments
Assignees

Comments

@tomasaschan
Copy link
Contributor

tomasaschan commented Jul 20, 2022

I want to build a controller that watches for RootSync objects, and tried to add

import configsync "kpt.dev/configsync/pkg/api/v1beta1"

at the top of the controller file.

However, then go mod tidy fails with this error, which seems like it should be fixable (it refers to files in examples which might not have to be bundled with the package, or named like this?):

 λ go mod tidy
go: finding module for package kpt.dev/configsync/pkg/api/v1beta1
go: downloading kpt.dev/configsync v0.0.0-20220719182314-469c8ee811cc
<redacted>/controllers imports
        kpt.dev/configsync/pkg/api/v1beta1: create zip: examples/kubevirt-compiled/clusterrole_kubevirt.io:operator.yaml: malformed file path "examples/kubevirt-compiled/clusterrole_kubevirt.io:operator.yaml": invalid char ':'
examples/kubevirt/cluster/kubevirt.io:operator-clusterrole.yaml: malformed file path "examples/kubevirt/cluster/kubevirt.io:operator-clusterrole.yaml": invalid char ':'
@janetkuo
Copy link
Contributor

janetkuo commented Aug 4, 2022

cc @mortent @mikebz

@janetkuo
Copy link
Contributor

janetkuo commented Aug 4, 2022

It seems that we could fix this by renaming clusterrole_kubevirt.io:operator.yaml and kubevirt.io:operator-clusterrole.yaml.

@sdowell
Copy link
Contributor

sdowell commented Aug 5, 2022

I'll take a look

@mikebz
Copy link
Contributor

mikebz commented Aug 12, 2022

this is fixed:

go  mod tidy
go: finding module for package kpt.dev/configsync/pkg/api/configsync/v1beta1
go: downloading kpt.dev/configsync v0.0.0-20220812180759-434145413977
go: found kpt.dev/configsync/pkg/api/configsync/v1beta1 in kpt.dev/configsync v0.0.0-20220812180759-434145413977

@mikebz mikebz closed this as completed Aug 12, 2022
tiffanny29631 added a commit to tiffanny29631/kpt-config-sync that referenced this issue May 28, 2024
…r start

The Count views won't show up in query results until data is sent when error
condition happens.

This change initialize these metrics and adjust the e2e test to check
for Rate aggregation.

The public documentation should also be revised to recommend the Rate
aggregation for this type of metrics.
tiffanny29631 added a commit to tiffanny29631/kpt-config-sync that referenced this issue May 28, 2024
…r start

The Count views won't show up in query results until data is sent when error
condition happens.

This change initialize these metrics and adjust the e2e test to check
for Rate aggregation.

The public documentation should also be revised to recommend the Rate
aggregation for this type of metrics.
tiffanny29631 added a commit to tiffanny29631/kpt-config-sync that referenced this issue Jun 20, 2024
…r start

The Count views won't show up in query results until data is sent when error
condition happens.

This change initialize these metrics and adjust the e2e test to check
for Rate aggregation.

The public documentation should also be revised to recommend the Rate
aggregation for this type of metrics.
tiffanny29631 added a commit to tiffanny29631/kpt-config-sync that referenced this issue Aug 20, 2024
…r start

The Count views won't show up in query results until data is sent when error
condition happens.

This change initialize these metrics and adjust the e2e test to check
for Rate aggregation.

The public documentation should also be revised to recommend the Rate
aggregation for this type of metrics.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants