Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix kubevirt file naming #554

Merged
merged 1 commit into from
Apr 24, 2023

Conversation

sdowell
Copy link
Contributor

@sdowell sdowell commented Apr 24, 2023

The colon in the file name breaks Go imports. This updates the kubevirt examples to not include any colons in file names.

Fixes:

Context:

The colon in the file name breaks Go imports. This updates the kubevirt
examples to not include any colons in file names.
@tiffanny29631
Copy link
Contributor

/lgtm

@sdowell
Copy link
Contributor Author

sdowell commented Apr 24, 2023

looks like both failures are metrics flakes
/retest

Copy link
Contributor

@karlkfi karlkfi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: karlkfi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 688b7a1 into GoogleContainerTools:main Apr 24, 2023
sdowell added a commit to sdowell/kpt-config-sync that referenced this pull request Apr 28, 2023
The colon in the file name breaks Go imports. This updates the kubevirt
examples to not include any colons in file names.
google-oss-prow bot pushed a commit that referenced this pull request Apr 28, 2023
The colon in the file name breaks Go imports. This updates the kubevirt
examples to not include any colons in file names.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants