-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: kubevirt-compiled support on windows #551
Conversation
Signed-off-by: hejianpeng <hejianpeng2@huawei.com>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @zirain. Thanks for your PR. I'm waiting for a GoogleContainerTools member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
@@ -35,4 +35,5 @@ Here are the steps for updating kubevirt-operator: | |||
rm -rf kubevirt-compiled | |||
nomos hydrate --path=kubevirt --source-format=unstructured --output kubevirt-compiled | |||
addlicense -v -c "Google LLC" -f ../LICENSE_TEMPLATE -ignore=vendor/** kubevirt-compiled 2>&1 | sed '/ skipping: / d' | |||
mv kubevirt-compiled/clusterrole_kubevirt.io:operator.yaml kubevirt-compiled/clusterrole_kubevirt.io-operator.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a note/comment in the doc here explaining why the file needs to be renamed?
@zirain: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
The failures in test groups 2/3 look to be known metrics flakes, but the failure in test group 1 looks like a genuine failure:
|
FYI I put up a similar PR: #554 |
replaced by #554 |
thanks @sdowell for fix this. |
:
is invalid on windows, make this repo cloneable on windows.