Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: kubevirt-compiled support on windows #551

Closed
wants to merge 1 commit into from

Conversation

zirain
Copy link

@zirain zirain commented Apr 24, 2023

: is invalid on windows, make this repo cloneable on windows.

Signed-off-by: hejianpeng <hejianpeng2@huawei.com>
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign haiyanmeng for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow
Copy link

Hi @zirain. Thanks for your PR.

I'm waiting for a GoogleContainerTools member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@sdowell sdowell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@@ -35,4 +35,5 @@ Here are the steps for updating kubevirt-operator:
rm -rf kubevirt-compiled
nomos hydrate --path=kubevirt --source-format=unstructured --output kubevirt-compiled
addlicense -v -c "Google LLC" -f ../LICENSE_TEMPLATE -ignore=vendor/** kubevirt-compiled 2>&1 | sed '/ skipping: / d'
mv kubevirt-compiled/clusterrole_kubevirt.io:operator.yaml kubevirt-compiled/clusterrole_kubevirt.io-operator.yaml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a note/comment in the doc here explaining why the file needs to be renamed?

@google-oss-prow
Copy link

@zirain: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
kpt-config-sync-presubmit-e2e-multi-repo-test-group2 38e687d link true /test kpt-config-sync-presubmit-e2e-multi-repo-test-group2
kpt-config-sync-presubmit-e2e-multi-repo-test-group1 38e687d link true /test kpt-config-sync-presubmit-e2e-multi-repo-test-group1
kpt-config-sync-presubmit-e2e-multi-repo-test-group3 38e687d link true /test kpt-config-sync-presubmit-e2e-multi-repo-test-group3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sdowell
Copy link
Contributor

sdowell commented Apr 24, 2023

The failures in test groups 2/3 look to be known metrics flakes, but the failure in test group 1 looks like a genuine failure:

  cli_test.go:573: Only in ../../examples/kubevirt-compiled: clusterrole_kubevirt.io-operator.yaml
        Only in /tmp/nomos-e2e/test-nomos-hydrate-with-unknown-scoped-object2598646333/compiled-without-api-server-check: clusterrole_kubevirt.io:operator.yaml
        
    cli_test.go:574: ERROR: exit status 1
    cli_test.go:591: Only in ../../examples/kubevirt-compiled: clusterrole_kubevirt.io-operator.yaml
        Only in /tmp/nomos-e2e/test-nomos-hydrate-with-unknown-scoped-object2598646333/compiled-with-api-server-check: clusterrole_kubevirt.io:operator.yaml
        
    cli_test.go:592: ERROR: exit status 1
=== CONT  TestRevertClusterRole

@sdowell
Copy link
Contributor

sdowell commented Apr 24, 2023

FYI I put up a similar PR: #554

@zirain
Copy link
Author

zirain commented Apr 25, 2023

replaced by #554

@zirain zirain closed this Apr 25, 2023
@zirain zirain deleted the kubevirt-compiled branch April 25, 2023 00:55
@zirain
Copy link
Author

zirain commented Apr 25, 2023

thanks @sdowell for fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants