Site examples patch version #666
Conversation
sdowell
requested review from
droot,
frankfarzan,
mengqiy and
phanimarupaka
as code owners
sdowell
force-pushed
the
site-examples-patch-version
branch
from
fb6cd3e
to
793cefb
Compare
Before clicking the dropdown:
After clicking the dropdown
|
|
I find that image URL to be really big and distracting. It also doesn't tell what that is. One possible presentation could be having a Image: (with the dimensions shown below code section of github)
|
sdowell
force-pushed
the
site-examples-patch-version
branch
from
793cefb
to
b0c9f84
Compare
|
One more question: if you change the version in the drop down, do the image URL also get changed ? I think we can also probably display it under the function heading: apply-settersImage URL: |
| } else { | ||
| catalogPath = "/catalog.json"; |
There was a problem hiding this comment.
Do we still serve catalog.json?
There was a problem hiding this comment.
Yes, it's still served at the same path
sdowell
force-pushed
the
site-examples-patch-version
branch
from
b0c9f84
to
1aab8ec
Compare
This endpoint provides a new schema for the catalog.json file. The motivation for this change is to provide access to the latest patch version for each major/minor version for each function. A new endpoint is added in order to avoid breaking backwards compatibility with existing consumers of the catalog.json endpoint, such as older versions of kpt already in the wild. Issues: kptdev/kpt#2609
sdowell
force-pushed
the
site-examples-patch-version
branch
from
1aab8ec
to
6c45a3c
Compare
Closing the loop on this. We discussed offline and decided to add this as an incremental change. Scope of this PR is now reduced to just ensuring content in the catalog has latest patch version instead of the minor versions. |
sdowell
force-pushed
the
site-examples-patch-version
branch
from
6c45a3c
to
4568b2e
Compare
Consumes the new catalog-v2.json endpoint which provides the latest patch versions. The latest patch version is now presented in the version dropdown for the function. Issues: kptdev/kpt#2609
sdowell
force-pushed
the
site-examples-patch-version
branch
from
4568b2e
to
c491320
Compare
Issue: kptdev/kpt#2609
This adds a new catalog-v2.json endpoint which expands upon the previous catalog.json schema to also include the latest patch version for each major/minor function release. This is presented as a new endpoint in order to avoid breaking compatibility with existing consumers of the original endpoint, such as versions of kpt already in the wild.
Updates the catalog pages of the website to include the latest patch version in: