Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

function catalog should make full version (vX.Y.Z) of all functions available #2609

Closed
droot opened this issue Dec 6, 2021 · 2 comments
Closed

function catalog should make full version (vX.Y.Z) of all functions available #2609

droot opened this issue Dec 6, 2021 · 2 comments
Assignees
@sdowell
Labels
enhancement New feature or request triaged Issue has been triaged by adding an `area/` label
Milestone
Q4-2021

Comments

@droot
Copy link
Contributor

droot commented Dec 6, 2021

We want to recommend users to use fully qualified version (vX.Y.Z) of functions in their packages to ensure that the render config is immutable but catalog seems to use floating version (vX.Y) today. So two asks:

  • Make it easy to discover all the patch versions of functions
  • All examples should use latest stable full versions.

Note: This is even more critical because very soon, we will make image-pull-policy to ifNotPresent.
@droot droot added enhancement New feature or request triaged Issue has been triaged by adding an `area/` label labels Dec 6, 2021
@droot
Copy link
Contributor Author

droot commented Dec 6, 2021

We should also ensure that kpt fn eval auto complete should display the latest patch version the function.

Note: our installation guide should document kpt completion to enable auto completion.

@mengqiy mengqiy mentioned this issue Dec 6, 2021
Closed
3 tasks
@droot droot added this to the Q4-2021 milestone Dec 6, 2021
sdowell added a commit to sdowell/kpt-functions-catalog that referenced this issue Dec 6, 2021
@sdowell
docs: Display patch versions in site catalog
ec63c1e 
Update the function catalog pages of the site to use the patch
version on the version dropdown. This is done using a new
catalog-v2.json endpoint in order to avoid breaking compatibility
with older versions of the CLI which are already in the wild.

Issues: kptdev/kpt#2609
sdowell added a commit to sdowell/kpt-functions-catalog that referenced this issue Dec 6, 2021
@sdowell
docs: Add latest image section to function site
1893a24 
This uses the fully qualified image name (patch version) to
provide a convenient means for the user to follow the best
practice of not using a floating version.

Issues: kptdev/kpt#2609
sdowell added a commit to sdowell/kpt-functions-catalog that referenced this issue Dec 6, 2021
@sdowell
docs: Add catalog-v2.json endpoint to site
26fc016 
This endpoint provides a new schema for the catalog.json file.
The motivation for this change is to provide access to the latest
patch version for each major/minor version for each function.
A new endpoint is added in order to avoid breaking backwards
compatibility with existing consumers of the catalog.json
endpoint, such as older versions of kpt already in the wild.

Issues: kptdev/kpt#2609
sdowell added a commit to sdowell/kpt-functions-catalog that referenced this issue Dec 6, 2021
@sdowell
docs: Display patch versions in site catalog
fb6cd3e 
Consumes the new catalog-v2.json endpoint which provides the
latest patch versions.
The latest patch version is now being presented in:
- The version dropdown for the function
- A new dynamic latest image tag section at the top of the page

Issues: kptdev/kpt#2609
@sdowell sdowell mentioned this issue Dec 6, 2021
Merged
sdowell added a commit to sdowell/kpt-functions-catalog that referenced this issue Dec 6, 2021
@sdowell
docs: Add catalog-v2.json endpoint to site
099b7d7 
This endpoint provides a new schema for the catalog.json file.
The motivation for this change is to provide access to the latest
patch version for each major/minor version for each function.
A new endpoint is added in order to avoid breaking backwards
compatibility with existing consumers of the catalog.json
endpoint, such as older versions of kpt already in the wild.

Issues: kptdev/kpt#2609
sdowell added a commit to sdowell/kpt-functions-catalog that referenced this issue Dec 6, 2021
@sdowell
docs: Display patch versions in site catalog
793cefb 
Consumes the new catalog-v2.json endpoint which provides the
latest patch versions.
The latest patch version is now being presented in:
- The version dropdown for the function
- A new dynamic latest image tag section at the top of the page

Issues: kptdev/kpt#2609
sdowell added a commit to sdowell/kpt-functions-catalog that referenced this issue Dec 8, 2021
@sdowell
docs: Add catalog-v2.json endpoint to site
d9768a2 
This endpoint provides a new schema for the catalog.json file.
The motivation for this change is to provide access to the latest
patch version for each major/minor version for each function.
A new endpoint is added in order to avoid breaking backwards
compatibility with existing consumers of the catalog.json
endpoint, such as older versions of kpt already in the wild.

Issues: kptdev/kpt#2609
sdowell added a commit to sdowell/kpt-functions-catalog that referenced this issue Dec 8, 2021
@sdowell
docs: Display patch versions in site catalog
b0c9f84 
Consumes the new catalog-v2.json endpoint which provides the
latest patch versions.
The latest patch version is now being presented in:
- The version dropdown for the function
- A new dynamic latest image tag section at the top of the page

Issues: kptdev/kpt#2609
sdowell added a commit to sdowell/kpt-functions-catalog that referenced this issue Dec 8, 2021
@sdowell
docs: Add catalog-v2.json endpoint to site
f61e4ac 
This endpoint provides a new schema for the catalog.json file.
The motivation for this change is to provide access to the latest
patch version for each major/minor version for each function.
A new endpoint is added in order to avoid breaking backwards
compatibility with existing consumers of the catalog.json
endpoint, such as older versions of kpt already in the wild.

Issues: kptdev/kpt#2609
sdowell added a commit to sdowell/kpt-functions-catalog that referenced this issue Dec 8, 2021
@sdowell
docs: Display patch versions in site catalog
1aab8ec 
Consumes the new catalog-v2.json endpoint which provides the
latest patch versions.
The latest patch version is now being presented in:
- The version dropdown for the function
- A new dynamic latest image tag section at the top of the page

Issues: kptdev/kpt#2609
sdowell added a commit to sdowell/kpt-functions-catalog that referenced this issue Dec 8, 2021
@sdowell
docs: Add catalog-v2.json endpoint to site
a14e21b 
This endpoint provides a new schema for the catalog.json file.
The motivation for this change is to provide access to the latest
patch version for each major/minor version for each function.
A new endpoint is added in order to avoid breaking backwards
compatibility with existing consumers of the catalog.json
endpoint, such as older versions of kpt already in the wild.

Issues: kptdev/kpt#2609
sdowell added a commit to sdowell/kpt-functions-catalog that referenced this issue Dec 8, 2021
@sdowell
docs: Display patch versions in site catalog
6c45a3c 
Consumes the new catalog-v2.json endpoint which provides the
latest patch versions.
The latest patch version is now being presented in:
- The version dropdown for the function
- A new dynamic latest image tag section at the top of the page

Issues: kptdev/kpt#2609
sdowell added a commit to sdowell/kpt-functions-catalog that referenced this issue Dec 9, 2021
@sdowell
docs: Display patch versions in site catalog
4568b2e 
Consumes the new catalog-v2.json endpoint which provides the
latest patch versions.
The latest patch version is now being presented in:
- The version dropdown for the function
- A new dynamic latest image tag section at the top of the page

Issues: kptdev/kpt#2609
sdowell added a commit to sdowell/kpt-functions-catalog that referenced this issue Dec 9, 2021
@sdowell
docs: Display patch versions in site catalog
c491320 
Consumes the new catalog-v2.json endpoint which provides the
latest patch versions. The latest patch version is now presented
in the version dropdown for the function.

Issues: kptdev/kpt#2609
mengqiy pushed a commit to GoogleContainerTools/kpt-functions-catalog that referenced this issue Dec 9, 2021
@sdowell
Site examples patch version (#666)
07660de 
* docs: Add catalog-v2.json endpoint to site

This endpoint provides a new schema for the catalog.json file.
The motivation for this change is to provide access to the latest
patch version for each major/minor version for each function.
A new endpoint is added in order to avoid breaking backwards
compatibility with existing consumers of the catalog.json
endpoint, such as older versions of kpt already in the wild.

Issues: kptdev/kpt#2609

* docs: Display patch versions in site catalog

Consumes the new catalog-v2.json endpoint which provides the
latest patch versions. The latest patch version is now presented
in the version dropdown for the function.

Issues: kptdev/kpt#2609
sdowell added a commit to sdowell/kpt-functions-catalog that referenced this issue Dec 10, 2021
@sdowell
docs: Add catalog-v2.json endpoint to site
c98cbe9 
This endpoint provides a new schema for the catalog.json file.
The motivation for this change is to provide access to the latest
patch version for each major/minor version for each function.
A new endpoint is added in order to avoid breaking backwards
compatibility with existing consumers of the catalog.json
endpoint, such as older versions of kpt already in the wild.

Issues: kptdev/kpt#2609
sdowell added a commit to sdowell/kpt-functions-catalog that referenced this issue Dec 10, 2021
@sdowell
docs: Display patch versions in site catalog
3469197 
Consumes the new catalog-v2.json endpoint which provides the
latest patch versions. The latest patch version is now presented
in the version dropdown for the function.

Issues: kptdev/kpt#2609
sdowell added a commit to sdowell/kpt-functions-catalog that referenced this issue Dec 10, 2021
@sdowell
docs: Display patch versions in site catalog
de01b34 
Consumes the new catalog-v2.json endpoint which provides the
latest patch versions. The latest patch version is now presented
in the version dropdown for the function.

Issues: kptdev/kpt#2609
mengqiy pushed a commit to GoogleContainerTools/kpt-functions-catalog that referenced this issue Dec 10, 2021
@sdowell
fix: Use minor version for version dropdown href (#673)
5c26848 
* docs: Add catalog-v2.json endpoint to site

This endpoint provides a new schema for the catalog.json file.
The motivation for this change is to provide access to the latest
patch version for each major/minor version for each function.
A new endpoint is added in order to avoid breaking backwards
compatibility with existing consumers of the catalog.json
endpoint, such as older versions of kpt already in the wild.

Issues: kptdev/kpt#2609

* docs: Display patch versions in site catalog

Consumes the new catalog-v2.json endpoint which provides the
latest patch versions. The latest patch version is now presented
in the version dropdown for the function.

Issues: kptdev/kpt#2609
@sdowell sdowell mentioned this issue Dec 10, 2021
Merged
@sdowell sdowell mentioned this issue Dec 21, 2021
Merged
@mengqiy
Copy link
Contributor

mengqiy commented Jan 5, 2022

This is done

@mengqiy mengqiy closed this as completed Jan 5, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sdowell sdowell

Labels
enhancement New feature or request triaged Issue has been triaged by adding an `area/` label
Projects
None yet
Milestone
Q4-2021
Development

No branches or pull requests
3 participants
@droot @mengqiy @sdowell