-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manifests apply order #2645
Comments
Relevance here is that @thomas-tabbaza is trying to create and use namespaces within his manifests, and is experiencing failures:
Namespaces are required to be ordered to the top:
There is some more discussion in kubernetes/kubernetes#16448. Skaffold's Apparently |
So, we create a single big list of manifests out of the manifest list and throw that at
I'm currently thinking we could do 3) and 2) for <1.14 and retire 2) when <1.14 kubectl versions are not supported (https://kubernetes.io/docs/setup/release/version-skew-policy/) ... |
Just passing the manifest files in the order they are listed in the Example: apiVersion: skaffold/v1beta13
kind: Config
deploy:
kubectl:
manifests:
# 1st file in the apply command
- traefik-ingress.yaml
# 2nd file in the apply command
- k8s-dashboard-ingress.yaml Currently, this is not the case, |
also related to #1781 |
Fix GoogleContainerTools#2645 Signed-off-by: David Gageot <david@gageot.net>
Fix GoogleContainerTools#2645 Signed-off-by: David Gageot <david@gageot.net>
Fix GoogleContainerTools#2645 Signed-off-by: David Gageot <david@gageot.net>
Fix GoogleContainerTools#2645 Signed-off-by: David Gageot <david@gageot.net>
Fix GoogleContainerTools#2645 Signed-off-by: David Gageot <david@gageot.net>
* List manifests in the order given by the user Fix #2645 Signed-off-by: David Gageot <david@gageot.net> * s/list/set/ Signed-off-by: David Gageot <david@gageot.net>
Manifests apply order
Expected behavior
Skaffold should apply the manifests in the order they are supplied in the
manifests
property.(see @briandealwis below for use case/context)
Actual behavior
Uses (apparently) alphabetical order for everything.
Information
Steps to reproduce the behavior
Whatever the order the manifests is in the
manifests
property,skaffold dev -v debug
still shows they are applied in the same order.The text was updated successfully, but these errors were encountered: