List manifests in the order given by the user #2729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgageot
requested review from
balopat,
nkubala,
priyawadhwa and
tejal29
as code owners
dgageot
force-pushed
the
fix-2645
branch
2 times, most recently
from
dfb539a
to
9b8f6eb
Compare
Codecov Report
|
nkubala
approved these changes
Aug 28, 2019
pkg/skaffold/util/util.go
Outdated
| @@ -84,22 +84,45 @@ func StrSliceInsert(sl []string, index int, insert []string) []string { | |||
| return newSlice | |||
| } | |||
|
|
|||
| // fileList holds a list of files, with no duplicate. | |||
| type fileList struct { | |||
There was a problem hiding this comment.
nit: this would be a set then, not a list :)
|
@nkubala should be good now |
nkubala
approved these changes
Aug 28, 2019
Fix GoogleContainerTools#2645 Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2645
Signed-off-by: David Gageot david@gageot.net