Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom artifacts with a dependency on a Dockerfile should support inferred sync #3751

Closed
dgageot opened this issue Feb 28, 2020 · 0 comments · Fixed by #3752
Closed

Custom artifacts with a dependency on a Dockerfile should support inferred sync #3751

dgageot opened this issue Feb 28, 2020 · 0 comments · Fixed by #3752
Assignees
@dgageot
Labels
area/sync build/custom

Comments

@dgageot
Copy link
Contributor

dgageot commented Feb 28, 2020

When a custom artifact as a dependency on a Dockerfile, we can assume the custom script is used to run something similar to docker build, with non supported flags or using a different tool.

In that case, it should be safe to support inferred sync mode.
dgageot added a commit to dgageot/skaffold that referenced this issue Feb 28, 2020
@dgageot
Support inferred sync on Custom artifacts with a Dockerfile
36f819d 
Fixes GoogleContainerTools#3751

Signed-off-by: David Gageot <david@gageot.net>
@dgageot dgageot mentioned this issue Feb 28, 2020
Merged
@dgageot dgageot self-assigned this Feb 28, 2020
dgageot added a commit that referenced this issue Feb 28, 2020
@dgageot
Support inferred sync on Custom artifacts with a Dockerfile (#3752)
7ee0c0b 
Fixes #3751

Signed-off-by: David Gageot <david@gageot.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dgageot dgageot

Labels
area/sync build/custom
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support inferred sync on Custom artifacts with a Dockerfile dgageot/skaffold
1 participant
@dgageot