Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support inferred sync on Custom artifacts with a Dockerfile #3752

Merged
merged 1 commit into from
Feb 28, 2020
Merged

Support inferred sync on Custom artifacts with a Dockerfile #3752

merged 1 commit into from
Feb 28, 2020

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Feb 28, 2020

Fixes #3751

Signed-off-by: David Gageot david@gageot.net

@codecov
Copy link

codecov bot commented Feb 28, 2020 •
edited
Loading

Codecov Report

Merging #3752 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted Files Coverage Δ
pkg/skaffold/sync/sync.go 72.57% <100%> (+0.31%) ⬆️

@tejal29 tejal29 self-assigned this Feb 28, 2020
@dgageot dgageot merged commit 7ee0c0b into GoogleContainerTools:master Feb 28, 2020
@fmotrifork fmotrifork mentioned this pull request Mar 11, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tejal29 tejal29 tejal29 approved these changes

@balopat balopat Awaiting requested review from balopat

@nkubala nkubala Awaiting requested review from nkubala

Assignees

@tejal29 tejal29

Labels
cla: yes size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Custom artifacts with a dependency on a Dockerfile should support inferred sync
3 participants
@dgageot @tejal29 @googlebot