Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify update checks #5711

Closed
3 tasks done
tejal29 opened this issue Apr 20, 2021 · 0 comments · Fixed by #5741
Closed
3 tasks done

Simplify update checks #5711

tejal29 opened this issue Apr 20, 2021 · 0 comments · Fixed by #5741
Assignees
@tejal29
Labels
area/update-check kind/todo implementation task/epic for the skaffold team planning/Q2-21 priority/p1 High impact feature/bug.
Milestone
v1.24.0

Comments

@tejal29
Copy link
Member

tejal29 commented Apr 20, 2021 •
edited
Loading

Fixes #5711 issues identified in internal code walk.

This is tracking issue. I might end up splitting these into smaller PRs or separate issues.

  • Simplify update check logic to suppress update check when updateCheck config in global config is false
    side effect: Always perform update checks, even for IDE users.Dependency: Check with IDEs
  • Only suppress update check prompts and survey --quiet and --interactive set to true
  • Add --user hidden flag and upload metrics with --user flag for all skaffold usages unless exportMetrics is disabled via config.
@tejal29 tejal29 added the kind/todo implementation task/epic for the skaffold team label Apr 20, 2021
@tejal29 tejal29 added this to the v1.23.0 milestone Apr 20, 2021
@tejal29 tejal29 self-assigned this Apr 20, 2021
This was referenced Apr 27, 2021
Merged
Merged
@aaron-prindle aaron-prindle modified the milestones: v1.23.0, v1.24.0 Apr 29, 2021
This was referenced Apr 30, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tejal29 tejal29

Labels
area/update-check kind/todo implementation task/epic for the skaffold team planning/Q2-21 priority/p1 High impact feature/bug.
Projects
None yet
Milestone
v1.24.0
Development

Successfully merging a pull request may close this issue.

Simplify update check tejal29/skaffold
2 participants
@tejal29 @aaron-prindle