Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable housekeeping messages for render #5770

Merged
merged 1 commit into from
May 2, 2021

Conversation

tejal29
Copy link
Member

@tejal29 tejal29 commented Apr 30, 2021

Relates to #5711 ,

With the new changes to "update check" (#5741) and metrics,

  1. update check and metrics prompt will happen on every run unless they are disabled.

This might break skaffold render if it's being used for the first time. This is true for CI usecase.
Since skaffold render spits out yaml, we should be disallowing any house keeping messages similar to skaffold diagnose

@tejal29 tejal29 requested a review from nkubala April 30, 2021 21:28
@tejal29 tejal29 requested a review from a team as a code owner April 30, 2021 21:28
@google-cla google-cla bot added the cla: yes label Apr 30, 2021
@tejal29 tejal29 mentioned this pull request Apr 30, 2021
@codecov
Copy link

codecov bot commented Apr 30, 2021

Codecov Report

Merging #5770 (0bcf1c3) into master (03e9a20) will increase coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5770      +/-   ##
==========================================
+ Coverage   70.68%   70.70%   +0.02%     
==========================================
  Files         423      428       +5     
  Lines       16168    16178      +10     
==========================================
+ Hits        11428    11439      +11     
+ Misses       3900     3896       -4     
- Partials      840      843       +3     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/render.go 44.44% <ø> (-1.99%) ⬇️
pkg/skaffold/schema/latest/v2/config.go 0.00% <0.00%> (ø)
pkg/skaffold/schema/latest/v2/upgrade.go 0.00% <0.00%> (ø)
pkg/skaffold/schema/v3alpha1/config.go 0.00% <0.00%> (ø)
pkg/skaffold/schema/v3alpha1/upgrade.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/runner.go 58.49% <0.00%> (-1.51%) ⬇️
pkg/skaffold/kubernetes/log.go
pkg/skaffold/kubernetes/logger/log.go 42.45% <0.00%> (ø)
pkg/skaffold/kubernetes/image_list.go 100.00% <0.00%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5acad2...0bcf1c3. Read the comment docs.

@tejal29 tejal29 enabled auto-merge (squash) April 30, 2021 21:49
@tejal29 tejal29 merged commit 108694a into GoogleContainerTools:master May 2, 2021
@tejal29 tejal29 deleted the fix_render branch July 21, 2021 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants