Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add files to the context tarball with Unix separators. #489

Merged
merged 1 commit into from
May 5, 2018

Conversation

dlorenc
Copy link
Contributor

@dlorenc dlorenc commented Apr 27, 2018

This should fix #442. I can't think of a good way to test this, since it would require running unit tests on Windows.

Any ideas?

@dgageot
Copy link
Contributor

dgageot commented Apr 27, 2018 via email

Copy link
Contributor

@dgageot dgageot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dgageot dgageot merged commit f67f813 into GoogleContainerTools:master May 5, 2018
@dcherniv
Copy link

@dgageot @dlorenc The issue was not fully resolved with the above PR, even though the tar built sucessfully it contained windows-style separators in the tar headers. It was failing to extract properly.
Please re-open and fix is attached here #693

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker cloudbuilder folder copy issues
3 participants