[442] - fixing incorrect position of tarPath argument #693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcherniv
requested review from
dgageot,
dlorenc,
r2d4 and
viglesiasce
as code owners
This was referenced Jun 17, 2018
|
Looks like there's a test error in travis. This one is unrelated to the other CI issue I fixed this morning. |
…d everything is peachy
dlorenc
approved these changes
Jun 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was tested on windows 7. Previously the header in the tar contained windows file separators and failed to extract properly on docker, creating files instead of the directory structure.
E.G. instead of /src/main/app.java directory structure, one would see \src\main\app.java file.
Fixes
#442
#489