Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Develocity integration by default #993

Merged
merged 2 commits into from
Oct 2, 2024

Conversation

liutikas
Copy link
Contributor

@liutikas liutikas commented Oct 1, 2024

Configuring develocity build scan additional detail publishing breaks Gradle project isolation #907

This change adds a new property com.gradleup.shadow.enableDevelocityIntegration that defaults to true, however it allows folks to set it to false and make shadow plugin usage project isolation safe.


  • CHANGELOG's "Unreleased" section has been updated, if applicable.

Configuring develocity build scan additional detail publishing breaks
Gradle project isolation GradleUp#907

This change adds a new property com.gradleup.shadow.enableDevelocityIntegration
that defaults to true, however it allows folks to set it to false and
make shadow plugin usage project isolation safe.
@Goooler
Copy link
Member

Goooler commented Oct 2, 2024

I'm considering removing develocity integration, WDYT?

@3flex
Copy link
Contributor

3flex commented Oct 2, 2024

Or, merge this but default to disabling the integration, and add a deprecation warning if it's enabled.

If nobody complains then remove it in a couple of months.

@Goooler Goooler changed the title Add a new gradle property to control develocity integration Disable Develocity integration by default Oct 2, 2024
@Goooler Goooler enabled auto-merge (squash) October 2, 2024 04:18
@Goooler Goooler merged commit 1888cb6 into GradleUp:main Oct 2, 2024
9 checks passed
@liutikas liutikas deleted the develocityflag branch October 2, 2024 05:51
@Goooler Goooler mentioned this pull request Nov 9, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants