Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable Develocity integration by default #993

Merged
merged 2 commits into from
Oct 2, 2024
Merged

Disable Develocity integration by default #993

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ce9afea
Add a new gradle property to control develocity integration
liutikas Oct 1, 2024
032ed0d
Disable Develocity integration by default
Goooler Oct 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/docs/changes/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,10 @@

## [Unreleased]

**Changed**

- Disable Develocity integration by default. ([#993](https://github.com/GradleUp/shadow/pull/993))


## [v8.3.2]

Expand Down
17 changes: 11 additions & 6 deletions src/main/groovy/com/github/jengelman/gradle/plugins/shadow/ShadowPlugin.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,17 @@ class ShadowPlugin implements Plugin<Project> {
plugins.apply(ShadowApplicationPlugin)
}

// Legacy build scan support for Gradle Enterprise, users should migrate to develocity plugin.
rootProject.plugins.withId('com.gradle.enterprise') {
configureBuildScan(rootProject)
}
rootProject.plugins.withId('com.gradle.develocity') {
configureBuildScan(rootProject)
boolean enableDevelocityIntegration = providers.gradleProperty(
"com.gradleup.shadow.enableDevelocityIntegration"
).map { it.toBoolean() }.getOrElse(false)
if (enableDevelocityIntegration) {
// Legacy build scan support for Gradle Enterprise, users should migrate to develocity plugin.
rootProject.plugins.withId('com.gradle.enterprise') {
configureBuildScan(rootProject)
}
rootProject.plugins.withId('com.gradle.develocity') {
configureBuildScan(rootProject)
}
}
}
}
Expand Down