feat(remote_wal): support persisting per-region unique metadata #2816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2816 +/- ##
===========================================
- Coverage 84.75% 84.41% -0.35%
===========================================
Files 730 733 +3
Lines 113790 114843 +1053
===========================================
+ Hits 96445 96947 +502
- Misses 17345 17896 +551 |
2 tasks
WenyXu
reviewed
Nov 24, 2023
Comment on lines
+112
to
+115
| fn region_meta_value_decoder(kv: KeyValue) -> Result<((), RegionMetaValue)> { | ||
| let value = RegionMetaValue::try_from_raw_value(&kv.value)?; | ||
| Ok(((), value)) | ||
| } |
There was a problem hiding this comment.
It seems like it always allocates a new function.
There was a problem hiding this comment.
@WenyXu Moved the function outside.
Comment on lines
+31
to
+32
| // TODO(niebayes): to be removed when `Kafka Remote Wal` is merged. | ||
| pub type KafkaTopic = String; |
There was a problem hiding this comment.
Could be WalTopic.
This was referenced Nov 27, 2023
niebayes
changed the title
| #[derive(Clone)] | ||
| pub struct RegionMeta { | ||
| region_id: RegionId, | ||
| topic: Option<KafkaTopic>, |
There was a problem hiding this comment.
I think wal_topic is more meaningful. If you agree, please rename all places that use "topic" in this file.
Comment on lines
+31
to
+32
| // TODO(niebayes): to be removed when `Kafka Remote Wal` is merged. | ||
| pub type KafkaTopic = String; |
There was a problem hiding this comment.
Could be WalTopic.
3 tasks
|
Closed for now and maybe reopened in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
Support persisting per-region unique metadata to kv backend through the
RegionMetadataManagerin theTableMetadataManager.This feature is currently to support persisting the allocated kafka topic for each region. Meta srv now is able to store per-region topics in the kv backend while handling create table requests. Datanode now is able to retrieve the stored per-region topics while re-opening regions for a table during initializing a region server.
Checklist
Refer to a related PR or issue link (optional)