fix: fix store all wal options #3149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WenyXu
added
O-chaos
WenyXu
force-pushed
the
fix/store-all-filter-wal-options
branch
from
199952c to
0aa8c8e
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3149 +/- ##
==========================================
- Coverage 85.41% 84.92% -0.50%
==========================================
Files 823 823
Lines 134797 134798 +1
==========================================
- Hits 115138 114473 -665
- Misses 19659 20325 +666 |
MichaelScofield
approved these changes
Jan 12, 2024
There was a problem hiding this comment.
I'm approving this PR to not block the release of v0.6. However, I don't think put all regions' wal options into DatanodeTableValue is a good idea. We need to redesign the table metadata to adapt the overlooked requirement of storing the infomation of regions.
|
Seems depends on this #2816 |
Yes, but it works now. Maybe we can refactor the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
Before we store all region wal options into table metadata or somewhere, we must store all region wal options.
Checklist
Refer to a related PR or issue link (optional)
#2700