-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: disable path label in opendal for now #5247
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5247 +/- ##
==========================================
- Coverage 83.94% 83.69% -0.25%
==========================================
Files 1198 1203 +5
Lines 222969 224150 +1181
==========================================
+ Hits 187177 187610 +433
- Misses 35792 36540 +748 |
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
Since switching to openDAL's Prometheus layer, we have not been able to set the layer multiple times, causing the path label to include the index`s uuid symbol, which causes the size of the label to explode.
Disable the path label for now because we're not using it for debugging anyway. We may reopen it later if openDAL supports dynamic path trim or some hook to decide path label dynamically.
PR Checklist
Please convert it to a draft if some of the following conditions are not met.