Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable path label in opendal for now #5247

Merged
merged 2 commits into from
Dec 27, 2024
Merged

fix: disable path label in opendal for now #5247

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
52d9882
fix: remove path label in opendal for now
shuiyisong Dec 27, 2024
63bf250
fix: typo
shuiyisong Dec 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions src/object-store/src/layers.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,13 +30,18 @@ mod prometheus {
/// pattern `<data|index>/catalog/schema/table_id/...` OR `greptimedb/object_cache/<read|write>/...`
///
/// We'll get the data/catalog/schema from path.
pub fn build_prometheus_metrics_layer(with_path_label: bool) -> PrometheusLayer {
pub fn build_prometheus_metrics_layer(_with_path_label: bool) -> PrometheusLayer {
PROMETHEUS_LAYER
.get_or_init(|| {
let path_level = if with_path_label { 3 } else { 0 };
// let path_level = if with_path_label { 3 } else { 0 };

// opendal doesn't support dynamic path label trim
// we have uuid in index path, which causes the label size to explode
// remove path label first, waiting for later fix
// TODO(shuiyisong): add dynamic path label trim for opendal

let layer = PrometheusLayer::builder()
.path_label(path_level)
.path_label(0)
.register_default()
.unwrap();

Expand Down
Loading