-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: add tests-integration module #590
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
license-eye has totally checked 611 files.
Valid | Invalid | Ignored | Fixed |
---|---|---|---|
520 | 1 | 90 | 0 |
Click to see the invalid file list
- tests-integration/src/lib.rs
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
3611c66
to
a785904
Compare
Codecov Report
@@ Coverage Diff @@
## develop #590 +/- ##
===========================================
- Coverage 86.35% 86.35% -0.01%
===========================================
Files 404 406 +2
Lines 51238 51307 +69
===========================================
+ Hits 44249 44305 +56
- Misses 6989 7002 +13
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
I just found that tests inside |
@v0y4g3r I checked that module and it seems for testing datanode only? Correct me if I'm wrong. |
That's right. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* refactor: add integration-tests module * Apply suggestions from code review Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * test: move grpc module to tests-integration * test: adapt new standalone mode * test: improve http assertion Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
While cleanup residual code review suggestions in #474 , I just realized this
http_test
is no longer suitable to sit indatanode
module:datanode
, it covers logic fromservers
,datanode
tofrontend
datanode
andfrontend
in terms of dependencyThis PR creates a dedicated tests-integration module to hold tests like
http_test
. It will depend ondatanode
,frontend
andmeta
in future. if this idea sounds good to you, I'm going to move forward:movestill in use for datanode's teststest_util
fromdatanode
intotests-integration
grpc_test
, which is similar to currenthttp_test
, intotests-integration
. And note thatdatanode
still needs its owngrpc_test
as unit test to test our internaldatanode
-frontend
communication.tests-integration
tests for mysql handler indatanode
is to be removed as in Remove MySQL server in datanode #556Checklist
Refer to a related PR or issue link (optional)
N/A