Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove MySQL server in datanode #556

Closed
v0y4g3r opened this issue Nov 17, 2022 · 6 comments · Fixed by #593
Closed

Remove MySQL server in datanode #556

v0y4g3r opened this issue Nov 17, 2022 · 6 comments · Fixed by #593
Assignees
Labels
C-enhancement Category Enhancements good first issue Good for newcomers

Comments

@v0y4g3r
Copy link
Contributor

v0y4g3r commented Nov 17, 2022

What type of enhancement is this?

Configuration

What does the enhancement do?

In standalone mode, there is no need to start MySQL server in both frontend and datanode. We can check running mode in datanode::server::Services and start MySQL server only in distribuited mode.

Implementation challenges

NA

@v0y4g3r v0y4g3r added the C-enhancement Category Enhancements label Nov 17, 2022
@v0y4g3r v0y4g3r self-assigned this Nov 17, 2022
@sunng87
Copy link
Member

sunng87 commented Nov 19, 2022

@v0y4g3r just to clarify, is this designed to disable mysql server in datanode, or to remove mysql protocol support in standalone mode?

@v0y4g3r
Copy link
Contributor Author

v0y4g3r commented Nov 19, 2022

@v0y4g3r just to clarify, is this designed to disable mysql server in datanode, or to remove mysql protocol support in standalone mode?

Both frontend and datanode will start MySQL server in standalone mode cuerently.
This issue is about to disable MySQL only in datanode.

@sunng87
Copy link
Member

sunng87 commented Nov 19, 2022

Sounds good, thanks!

@MichaelScofield
Copy link
Collaborator

MichaelScofield commented Nov 19, 2022 via email

@v0y4g3r
Copy link
Contributor Author

v0y4g3r commented Nov 19, 2022

In standalone mode, why dn needs a mysql server? dn could only expose local grpc service for fe.

To be clarify:

  • In standalone mode, dn starts grpc only
  • In distributed mode, dn starts grpc and mysql
  • In either mode, fe is communicating with dn via grpc

Mysql server in dn is only used for debugging purpose in distributed mode. Since the underlying env is unstable when dn and fe are deployed distributed, it’s good to directly manually check dn’s data. In standalone mode, because dn and fe are “packed” in one process, I think we don’t need to do that.

2022年11月19日 19:46,Lei, HUANG @.***> 写道:

@v0y4g3r https://github.com/v0y4g3r just to clarify, is this designed to disable mysql server in datanode, or to remove mysql protocol support in standalone mode?

Both frontend and datanode will start MySQL server in standalone mode.
This issue is about to disable MySQL only in datanode.


Reply to this email directly, view it on GitHub #556 (comment), or unsubscribe https://github.com/notifications/unsubscribe-auth/AAHR2D2QXR5SE6NB5ZCQQETWJC4XVANCNFSM6AAAAAASDBYLBQ.
You are receiving this because you are subscribed to this thread.

That's exactly what this issue is about 🙃

@killme2008 killme2008 added the good first issue Good for newcomers label Nov 19, 2022
@sunng87
Copy link
Member

sunng87 commented Nov 20, 2022

Let me update this issue's title

@sunng87 sunng87 changed the title Remove MySQL server in standalone mode Remove MySQL server in datanode Nov 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category Enhancements good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants