Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: disable mysql server on datande when running standalone mode #593

Merged

Conversation

v0y4g3r
Copy link
Contributor

@v0y4g3r v0y4g3r commented Nov 20, 2022

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Disable mysql server on datande when running standalone mode

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

Fixes #556

@codecov
Copy link

codecov bot commented Nov 20, 2022

Codecov Report

Merging #593 (f7f6495) into develop (c94b544) will decrease coverage by 0.01%.
The diff coverage is 3.70%.

@@             Coverage Diff             @@
##           develop     #593      +/-   ##
===========================================
- Coverage    86.47%   86.45%   -0.02%     
===========================================
  Files          399      399              
  Lines        50640    50649       +9     
===========================================
- Hits         43790    43789       -1     
- Misses        6850     6860      +10     
Flag Coverage Δ
rust 86.45% <3.70%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/cmd/src/datanode.rs 81.69% <ø> (ø)
src/cmd/src/frontend.rs 65.51% <ø> (ø)
src/cmd/src/standalone.rs 37.35% <ø> (ø)
src/datanode/src/datanode.rs 52.63% <ø> (ø)
src/datanode/src/instance.rs 35.07% <ø> (ø)
src/datanode/src/server.rs 0.00% <0.00%> (ø)
src/frontend/src/frontend.rs 48.57% <ø> (-1.43%) ⬇️
src/frontend/src/instance.rs 73.31% <ø> (ø)
src/frontend/src/instance/influxdb.rs 0.00% <ø> (ø)
src/frontend/src/instance/opentsdb.rs 91.20% <ø> (ø)
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, but we have to remove the MySQL options in StandaloneOptions too. https://github.com/GreptimeTeam/greptimedb/blob/develop/src/cmd/src/standalone.rs#L73-L74

src/datanode/src/server.rs Outdated Show resolved Hide resolved
src/datanode/src/server.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@killme2008 killme2008 merged commit ca5734e into GreptimeTeam:develop Nov 21, 2022
@waynexia waynexia added the docs-required This change requires docs update. label Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-required This change requires docs update.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove MySQL server in datanode
4 participants