-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: disable mysql server on datande when running standalone mode #593
feat: disable mysql server on datande when running standalone mode #593
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #593 +/- ##
===========================================
- Coverage 86.47% 86.45% -0.02%
===========================================
Files 399 399
Lines 50640 50649 +9
===========================================
- Hits 43790 43789 -1
- Misses 6850 6860 +10
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job, but we have to remove the MySQL options in StandaloneOptions
too. https://github.com/GreptimeTeam/greptimedb/blob/develop/src/cmd/src/standalone.rs#L73-L74
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
Disable mysql server on datande when running standalone mode
Checklist
Refer to a related PR or issue link (optional)
Fixes #556