Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove datanode mysql options in standalone mode #595

Merged

Conversation

v0y4g3r
Copy link
Contributor

@v0y4g3r v0y4g3r commented Nov 21, 2022

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Remove datanode_mysql_addr/datanode_mysql_runtime_size from StandaloneOptions.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

NA

@codecov
Copy link

codecov bot commented Nov 21, 2022

Codecov Report

Merging #595 (23d59a4) into develop (ca5734e) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #595   +/-   ##
========================================
  Coverage    86.45%   86.45%           
========================================
  Files          399      399           
  Lines        50649    50645    -4     
========================================
- Hits         43788    43786    -2     
+ Misses        6861     6859    -2     
Flag Coverage Δ
rust 86.45% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/cmd/src/standalone.rs 38.23% <ø> (+0.87%) ⬆️
src/servers/src/mysql/handler.rs 64.13% <0.00%> (-1.09%) ⬇️
src/meta-srv/src/service/heartbeat.rs 86.31% <0.00%> (-1.06%) ⬇️
src/servers/src/opentsdb/codec.rs 98.93% <0.00%> (-0.36%) ⬇️
src/log-store/src/fs/file.rs 88.88% <0.00%> (+0.16%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sunng87 sunng87 merged commit 2b6b979 into GreptimeTeam:develop Nov 21, 2022
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants