Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove datanode mysql options in standalone mode #595

Merged
merged 1 commit into from
Nov 21, 2022
Merged

fix: remove datanode mysql options in standalone mode #595

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions config/standalone.example.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
node_id = 0
mode = 'standalone'
http_addr = '127.0.0.1:4000'
datanode_mysql_addr = '127.0.0.1:4406'
datanode_mysql_runtime_size = 4
wal_dir = '/tmp/greptimedb/wal/'

[storage]
Expand Down
6 changes: 0 additions & 6 deletions src/cmd/src/standalone.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,8 +71,6 @@ pub struct StandaloneOptions {
pub mode: Mode,
pub wal_dir: String,
pub storage: ObjectStoreConfig,
pub datanode_mysql_addr: String,
pub datanode_mysql_runtime_size: usize,
}

impl Default for StandaloneOptions {
Expand All @@ -88,8 +86,6 @@ impl Default for StandaloneOptions {
mode: Mode::Standalone,
wal_dir: "/tmp/greptimedb/wal".to_string(),
storage: ObjectStoreConfig::default(),
datanode_mysql_addr: "127.0.0.1:4406".to_string(),
datanode_mysql_runtime_size: 4,
}
}
}
Expand All @@ -114,8 +110,6 @@ impl StandaloneOptions {
DatanodeOptions {
wal_dir: self.wal_dir,
storage: self.storage,
mysql_addr: self.datanode_mysql_addr,
mysql_runtime_size: self.datanode_mysql_runtime_size,
..Default::default()
}
}
Expand Down