BGRA Fixes #44
Open
BGRA Fixes #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Correct. I'm working on a revamped dialog that should have a unified, flexible import/export. |
Hoikas
force-pushed
the
bgra
branch
2 times, most recently
from
1845165
to
6aa9853
Compare
|
I updated the pull request to not change the RGB bitmask on the |
zrax
reviewed
Mar 5, 2024
All Plasma image data, other than DXT, is stored as BGR in plMipmap
|
The CI failure here is due to H-uru/libhsplasma#127 being a prerequisite of this. |
zrax
reviewed
Mar 6, 2024
Co-authored-by: Michael Hansen <zrax0111@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plasma stores its image data in
plMipmapas BGR(A), with the exception of DXT formatted data. This changeset updates PRPShop to match the fixes in libHSPlasma in that regard. Also teaches PRPShop about PNG compressed images. I believe a more complete changeset from @Deledrius is incoming to improve the import/export image options.Depends on: