Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify Import/Export of Mipmaps. #69

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Unify Import/Export of Mipmaps. #69

wants to merge 7 commits into from

Conversation

Deledrius
Copy link
Member

Adds an improved, unified interface for importing/exporting plMipmaps to and from supported formats.

Depends on #44 and H-uru/libhsplasma#255

@Deledrius
Copy link
Member Author

Up for discussion on this is:

  • This removes reading/writing of JPEG Alpha files. Are these still necessary now that we easily read/write formats that support alpha natively?
  • This reads all images into an uncompressed image data buffer and stores them this way. Would it be preferred to read them directly into the same image compression as the file itself when possible?

@Hoikas @Deledrius
Teach PRPShop about PNG compressed mipmaps
c2deffe
@Hoikas @Deledrius
Fix non-DXT image channels
a3f3abe 
All Plasma image data, other than DXT, is stored as BGR in plMipmap
@Hoikas Hoikas mentioned this pull request Mar 5, 2024
Merged
@dgelessus dgelessus mentioned this pull request Mar 5, 2024
Merged
@Deledrius Deledrius requested review from zrax and Hoikas March 5, 2024 22:47
@Deledrius @zrax
Consolidate byte-swapping for color components.
5a2d271 
Co-authored-by: Michael Hansen <zrax0111@gmail.com>
Hoikas
Hoikas reviewed Nov 11, 2024
View reviewed changes
src/PrpShop/PRP/Surface/QMipmap.cpp Outdated Show resolved Hide resolved
src/PrpShop/PRP/Surface/QMipmap.cpp Outdated Show resolved Hide resolved
src/PrpShop/PRP/Surface/QMipmap.cpp Outdated Show resolved Hide resolved
src/PrpShop/PRP/Surface/QMipmap.cpp Outdated Show resolved Hide resolved
src/PrpShop/PRP/Surface/QMipmap.cpp Outdated Show resolved Hide resolved
src/PrpShop/PRP/Surface/QMipmap.cpp Outdated Show resolved Hide resolved
src/PrpShop/PRP/Surface/QMipmap.cpp Outdated Show resolved Hide resolved
src/PrpShop/PRP/Surface/QMipmap.cpp Outdated Show resolved Hide resolved
src/PrpShop/PRP/Surface/QMipmap.cpp Outdated Show resolved Hide resolved
src/PrpShop/PRP/Surface/QMipmap.cpp Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hoikas Hoikas Hoikas left review comments

@zrax zrax zrax left review comments

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Deledrius @zrax @Hoikas