Allow displaying age/page and object IDs in Object Browser tree #78
Conversation
This allows showing object IDs as decimal instead of fixed-width hex while still sorting as expected.
This no longer works for pages now that they might have IDs displayed. For ages it's technically still fine, but better to fix those as well to avoid unpleasant surprises later.
|
One thing to definitely be aware of here is that not all versions of the engine have object IDs (in particular, older versions of Uru), and libHSPlasma will invent numbers in that case based on the order that objects are opened. That's generally fine because those numbers never get written back, because they don't exist in the data for that engine version. We've had so many changes to attempt to fix object ID issues in MOUL data that I can't say for sure what the current behaviour is. I believe the default behaviour is to re-assign all the object IDs when reading in a file, but there's an option to make it preserve IDs (which will cause problems if you ever add or remove objects) |
|
Ah, that's good to know - I wasn't aware that old Uru didn't use object IDs. I assumed that they always existed, because I suppose we could hide the object IDs for data from Plasma versions that don't actually use object IDs? Or if the object IDs aren't meaningful at all in PRPShop because libHSPlasma reassigns them on load, then I can remove that part again. |
|
Yeah, it seems that the object IDs are indeed always assigned sequentially by libHSPlasma - presumably in the order that the objects appear in the .prp files. If I manually add So it seems that displaying object IDs is only useful in a configuration that PrpShop doesn't actually support at the moment 🙁 It would be nice if PrpShop supported enabling |
|
I'll set this to draft for now, because displaying object IDs doesn't make sense with the current behavior of PlasmaShop/libHSPlasma. Will probably re-submit the age/page ID display as its own PR, because that part works fine and applies to all Plasma versions. |
|
Superseded by #84. |
We already have an option to display the type IDs next to the class names. This PR adds similar options for displaying the age/page IDs next to page names and object IDs next to object names. For example:
This also refactors
QPlasmaTreeItema bit so that the items are properly sorted numerically by their ID (when shown). Previously, the sorting was lexicographic based on the displayed text, which doesn't work for variable-length numbers (e. g. 1, 2, 10 was sorted as 1 < 10 < 2).One thing I'm not sure about: I remember something about libHSPlasma automatically changing object IDs in some cases. I don't know if the displayed object IDs might sometimes be inaccurate because of that...