Allow displaying age/page IDs in Object Browser tree #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This no longer works for pages now that they might have IDs displayed. For ages it's technically still fine, but better to fix those as well to avoid unpleasant surprises later.
dgelessus
force-pushed
the
show_age_page_ids
branch
from
e4ee6b9
to
a7d27b4
Compare
dpogue
reviewed
Mar 10, 2024
src/PrpShop/QPlasmaTreeItem.cpp
Outdated
| break; | ||
|
|
||
| case kTypeAge: | ||
| setText(0, fAge); |
There was a problem hiding this comment.
Would we want to show the sequence prefix next to Age folder names too? It's probably rare that people are opening multiple Ages in PlasmaShop, but the wording of "Show Age/Page IDs" makes me expect it would also be displayed at the Age level
There was a problem hiding this comment.
Yeah, that would make sense. I think I was too lazy to implement that part because the age items currently only store the name and not the sequence prefix... But it shouldn't be hard to add the extra field for that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #78. Adds an option to display age/page IDs next to page names, similar to the existing option to display type IDs next to class names.