Fix Layer SDL Animation base class editor #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The base class of plLayerSDLAnimation is actually plLayerAnimationBase and not plLayerAnimation. This was declared inconsistently in libHSPlasma (see H-uru/libhsplasma#281).
Fixes the "Layer Animation Properties" link in QLayerSDLAnimation now opening a PRC editor after the previous commit.
dgelessus
force-pushed
the
fix_pllayersdlanimation_base_class
branch
from
ddebf0a
to
fe42638
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to (but technically not dependent on) H-uru/libhsplasma#281. This does two things:
QLayerSDLAnimationto cast to the correct base class (plLayerAnimationBase). Previously, clicking the link crashed PrpShop.QLayerAnimationBaseeditor to support the link with the corrected class. This editor is split out ofQLayerAnimation, and I've made that link to the new editor as well, instead of having the base class editor "inline". (This matches how PrpShop handles other base class chains like this, e. g. the Win32 sounds.)Before:
After: